Skip to content

QUIET Feature #292

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 2 commits into from
Closed

QUIET Feature #292

wants to merge 2 commits into from

Conversation

asensio-project
Copy link
Contributor

Hello,

This PR adds a Quiet feature for avoiding the bootloader to write to the screen.
It sets the log filter in error when the feature is enabled.

Thanks.

@asensio-project asensio-project mentioned this pull request Nov 30, 2022
Closed
@asensio-project
Copy link
Contributor Author

Closes #288

@asensio-project asensio-project marked this pull request as draft December 1, 2022 13:39
@phil-opp
Copy link
Member

Thanks for submitting this PR! Unfortunately, I don't think that it works this way because the common library is built as part of the build script, which doesn't pass any cargo features. I think it would make more sense to add this as a runtime config option in the BootloaderConfig struct.

@asensio-project asensio-project mentioned this pull request Dec 30, 2022
Merged
@asensio-project
Copy link
Contributor Author

Thanks for submitting this PR! Unfortunately, I don't think that it works this way because the common library is built as part of the build script, which doesn't pass any cargo features. I think it would make more sense to add this as a runtime config option in the BootloaderConfig struct.

Thanks for the feedback, I published a PR, #303 for applying the changes that you requested. It's ready for review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@asensio-project @phil-opp